Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #430, unit-tests/osloader-test: make modules always be built for the test #431

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix #430, unit-tests/osloader-test: make modules always be built for the test #431

merged 1 commit into from
Apr 28, 2020

Conversation

stanislaw
Copy link
Contributor

Describe the contribution

Fixes #430.

Testing performed

Running osal_loader_UT on macOS as described in the linked issue.

Expected behavior changes

Without this patch, the MODULE* files are not generated in the build folder.

After this patch is applied, the module files are generated when the osal_loader_UT test is built and run:

$ find . | grep MODULE.*dy
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE31.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE5.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE28.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE7.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE3.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE6.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE30.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE29.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE4.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE0.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE2.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE23.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE21.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE8.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE25.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE27.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE20.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE22.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE26.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE24.dylib
./cmake-build-debug/unit-tests/osloader-test/eeprom1/MODULE9.dylib

System(s) tested on

  • Hardware: MacBook
  • OS: macOS Mojave 10.14.6 (18G1012)
  • Versions: OSAL as of a66eb2d commit.

Additional context

None.

Third party code

None.

Contributor Info - All information REQUIRED for consideration of pull request

Stanislav Pankevich, PTS GmbH

The hand signed CLA has been sent before.

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 21, 2020
@stanislaw stanislaw mentioned this pull request Apr 22, 2020
Closed
14 tasks
@skliper
Copy link
Contributor

skliper commented Apr 22, 2020

20200422 - CCB conditionally approved, will test

@skliper skliper added CCB - 20200422 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 22, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 27, 2020 22:58
@astrogeco astrogeco merged commit 230ba68 into nasa:integration-candidate Apr 28, 2020
@astrogeco
Copy link
Contributor

@skliper I prematurely merged this into the integration candidate, what are the tests you wanted to do?

@skliper
Copy link
Contributor

skliper commented Apr 28, 2020

@astrogeco it's fine to merge into IC. @jphickey just wanted to test/review closely.

@astrogeco astrogeco mentioned this pull request Apr 30, 2020
Merged
@astrogeco astrogeco changed the title unit-tests/osloader-test: make modules always be built for the test Fix #430, unit-tests/osloader-test: make modules always be built for the test May 1, 2020
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
@astrogeco astrogeco mentioned this pull request Oct 26, 2020
Closed
@stanislaw stanislaw deleted the osal-loader branch October 26, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

When running standalone, osal_loader_UT test binary file is missing test module files
3 participants
@stanislaw @skliper @astrogeco